pickware / shopware-platform

Shopware platform mono repository
https://shopware.com
MIT License
1 stars 1 forks source link

Add CriteriaFactory to application container #11

Closed hanneswernery closed 5 years ago

hanneswernery commented 5 years ago

1. Why is this change necessary?

The CriteriaFactory is missing from the factory container.

2. What does this change do, exactly?

Adds the CriteriaFactory to the factory container so it can be used using

const CriteriaFactory = Shopware.Application.getContainer('factory').criteria;

instead of

import CriteriaFactory from 'src/core/factory/criteria.factory';

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

ghost commented 5 years ago

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by :no_entry_sign: dangerJS

fixpunkt commented 5 years ago

CriteriaFactory is obsolete: https://docs.shopware.com/en/shopware-platform-dev-en/getting-started/recent-updates#2019-04-02-new-admin-data-handling