Fix building of super call cain - Githubissues

pickware / shopware-platform

Shopware platform mono repository

https://shopware.com

MIT License

1 stars 1 forks source link

Fix building of super call cain #16

Closed windaishi closed 4 years ago

windaishi commented 4 years ago

1. Why is this change necessary?

There is a special case where the call of ComponentFactory.extend would lead to an error:

This when the inheritance chain is like the following:

Child extends Parent extends Grandparent.
Child overrides method foo from component Parent, but foo does not exist in Grandparent

2. What does this change do, exactly?

It hopefully fixes the error. Would be nice if someone would double check the fix.

3. Describe each step to reproduce the issue or behaviour.

Please see the unit tests.

4. Please link to the relevant issues (if any).

5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

ghost commented 4 years ago

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by :no_entry_sign: dangerJS

windaishi commented 4 years ago

Closed in favor of https://github.com/shopware/platform/pull/412