search

picmi-standard / picmi

Standard input format for Particle-In-Cell codes
https://picmi.readthedocs.io
Other
35 stars 25 forks source link

In the Grid classes, only save the vectors #69

Closed dpgrote closed 2 years ago

dpgrote commented 2 years ago

In the Grid classes, the user can specify either the individual attributes (such as nx, ny, and nz) or can specify a vector of values (as in number_of_cells). This PR changes the internals so that only the vectors are saved. This avoids the possibility of having the two different values being inconsistent.

This is a change in the internals of PICMI and will affect implementations (it is not backwards compatible). The implementation will need to use the vectors to access the user input parameters.

I note that FBPIC will need to be updated.

First spotted in #60

Note that when changing to the data class scheme, this PR becomes moot.

RemiLehe commented 2 years ago

Thanks for this PR @dpgrote. It seems that there is a small conflict ; could you fix it?