Scalafmt basic setup - Githubissues

picnicml / doddle-model

:cake: doddle-model: machine learning in Scala.

https://picnicml.github.io

Apache License 2.0

137 stars 23 forks source link

Scalafmt basic setup #98

Open Helw150 opened 5 years ago

Helw150 commented 5 years ago

Description of Changes

Adds Basic Scalafmt support via SBT

Adds basic support for https://github.com/picnicml/doddle-model/issues/95

Includes

[x] Code changes
[ ] Tests
[ ] Documentation

Helw150 commented 5 years ago

@inejc Here's my personal setup for Scalafmt - feel free to make changes as you please (If you'd like I can also add a format of the whole project to this PR so you can see what these settings would do)

Helw150 commented 5 years ago

@inejc Finally had a bit of free time, here's what Scalafmt does to everything

inejc commented 5 years ago

@Helw150 this is really cool, I like it. We have a pretty big PR waiting to be merged (https://github.com/picnicml/doddle-model/pull/107) and in light of avoiding complex conflicts, I suggest we wait with this one and run Scalafmt again once https://github.com/picnicml/doddle-model/pull/107 is merged. Would that work for you?

inejc commented 5 years ago

Ok so after a discussion with @matejklemen, we want to:

~merge https://github.com/picnicml/doddle-model/pull/107~
rebase + merge https://github.com/picnicml/doddle-model/pull/69
run scalafmt on a rebased branch again and merge it

Helw150 commented 5 years ago

Yup, easy enough for me to wait and run the format after that gets merged