pico-coder / sigrok-pico

Use a raspberry pi pico (rp2040) as a logic analyzer and oscilloscope with sigrok
727 stars 83 forks source link

Support for other GUI ? #29

Open mtk11 opened 1 year ago

mtk11 commented 1 year ago

Have you considered supporting other GUI. DSView looks better than PulseView, the oscilloscope window looks as oscilloscope and it is also based on libsigrok.

pico-coder commented 1 year ago

While it's open source, DSView only supports DS devices, and I have a feeling that they wouldn't want to support other devices in their downloads. While I do provide Windows executables I'm really hoping to get out of the business of supplying executables (libsigrok repo moderators are reviewing my pull request now). Looking at the DSView screenshots it doesn't look all that different from what I see in PulseView. Can you give a better description of what you mean by it looking like an oscilloscope?

mtk11 commented 1 year ago

As far as I am aware the Basic edition of DSLogic is not officially sold anymore. The Plus edition is 400MHz sampling rate product. Do not think that Pico would be a direct competition to their products. DSLogic series offers an advance triggering that includes 16-stage trigger flag. Each stage support logic operation (and/or) of 2 sets of trigger. Each set support edge/level trigger of all channels, invert and counter. For more info look at p.17 Advanced Trigger DSView_User_Guide.pdf.

DSView1

The oscilloscope has FFT, MATH functions, X-Y mode etc. Some screenshots:

DSView2

DSView3

Wouldn’t be something easy to add the support to their version of libsigrok ?

pico-coder commented 1 year ago

Rule #1 with Open Source anything:

Based on a very quick scan it looks like they may have removed the usb CDC serial libraries that baseline sigrok provides. My code assumes a "serial" like implementation. Also, it looks like they may have extended the configuration space which we'd need to migrate to interact with the DSView code.

Even if we aren't a competitor, which we definitely aren't, that doesn't mean DSLogic will want to support what is in this repo, nor will they likely want to release builds to include this device. You are welcome to prove me wrong on that front by submitting an issue to their github repo on the topic and see what they say. Alternately, it might be worthwhile to see if their FFT and other features could be pulled into the mainline pulseview repo. I haven't looked into what that might look like, but probably not easy either.....

FFT, more advanced triggering and other features are definitely interesting, it's just not clear what the easiest path to done is...