search

picocms / Pico

Pico is a stupidly simple, blazing fast, flat file CMS.
http://picocms.org/
MIT License
3.83k stars 614 forks source link

config.php - defaults always used. #195

Closed diversemix closed 9 years ago

diversemix commented 9 years ago

I change the title of the site by editing config.php and altering the line: $config['site_title']

However this did not change the site's title. If I edit "lib/pico.php" and alter line 192 to change the default then this is reflected in the site.

xor-gate commented 9 years ago

I have exact the same problem:

OS: Arch Linux HTTP Server: Apache Server version: Apache/2.4.10 (Unix) PHP: 5.6.3

I tried to debug: https://github.com/picocms/Pico/blob/master/lib/pico.php#L186 Then var_dump($config) resulted in NULL. Which seems not to load the variable. I tried to output the result of include_once and it returns true.

cmattoon commented 9 years ago

Can you confirm you've removed the block comments (lines 3 and 23 in config.php)?

diversemix commented 9 years ago

You are correct. These lines are still commented out ... I was misled by the comment "Override any of the default settings below:" .. Can I suggest the comment is changed to something like "Please un-comment this code to override any of the default settings below:"

I think my preferred option would not to have the code commented out, is there a reason for this?

Anyway thanks again for you help :+1:

mistergraphx commented 9 years ago

The only reason i can see : is for documentation purpose ;-) like in other apps php config

The multiline style comment is not the most appropriate in this case. May it's better to use the one line style comment // so the user could uncomment line by line ...