search

picocms / Pico

Pico is a stupidly simple, blazing fast, flat file CMS.
http://picocms.org/
MIT License
3.81k stars 616 forks source link

404.md doesn't give a 404 #556

Closed Discostu36 closed 3 years ago

Discostu36 commented 3 years ago

If I open a page that doesn't exist, the 404 page is opened. But the server does not give a 404 response but a 200. Is this a problem in my installation?

Lomanic commented 3 years ago

Are you using @rewdy's Pagination plugin by any chance? In this case, see my comment here https://github.com/picocms/Pico/issues/551#issuecomment-652521872

Discostu36 commented 3 years ago

Are you using @rewdy's Pagination plugin by any chance? In this case, see my comment here #551 (comment)

Actually, I do. The problem disappeared with your version. Thank you very much! I think that your fork should be listed on the plugin page instead of the original.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two days if no further activity occurs. Thank you for your contributions! :+1:

Discostu36 commented 3 years ago

I still think the plugin page should be changed

PhrozenByte commented 3 years ago

A pull request is welcome :+1:

Lomanic commented 3 years ago

No need to change anything as the MR is now merged. This issue should be closed.