picocms / Pico

Pico is a stupidly simple, blazing fast, flat file CMS.
http://picocms.org/
MIT License
3.81k stars 616 forks source link

Enhanced Sorting by Nested Meta Values in Pages #681

Closed PxaMMaxP closed 7 months ago

PxaMMaxP commented 7 months ago

This pull request introduces an enhancement to the sorting functionality within pages. Previously, sorting was limited to top-level meta values. With this update, the sorting logic now supports nested meta values, providing greater flexibility and precision in organizing content.

Key Changes:

PxaMMaxP commented 7 months ago

I am thrilled to hear that my contribution is well-received – it's truly gratifying to see my code being integrated and knowing it will be used by others. Thank you very much for your positive feedback! 😊

Regarding the changelog, I wanted to suggest the following line for inclusion to accurately reflect the new functionality introduced:

Suggested Changelog Entry:

* [New] Enhance `pages_order_by_meta` functionality to allow sorting by nested meta values using '.' notation (e.g., 'author.info')

I apologize for the earlier commit and revert commit confusion. To avoid further complexities, I thought it best to propose the changelog update here. If you'd prefer a separate pull request for this, please let me know, and I'll be happy to arrange that.

Thank you once again for your support and for fostering such a collaborative environment.

PxaMMaxP commented 7 months ago

A little tinkering led to success: The changelog has now been changed accordingly!

Thanks again for your patience!

PhrozenByte commented 7 months ago

Looks like there went something wrong, the line wrapping in config.yml.template was lost again (I assume because you didn't pull after you've committed the change via GitHub's "Commit suggestion" feature; you can use git pull --rebase if you have unpushed commits locally). While you're at it, can you also add line wraps in CHANGELOG.md matching the line length of the other entries as well? Thanks again! :+1:

PxaMMaxP commented 7 months ago

Thanks again for your patience!

It should be correct now, right?