search

picocms / picocms.github.io

This is the repository of Pico's official website. Pico is a stupidly simple, blazing fast, flat file CMS.
http://picocms.org/
29 stars 37 forks source link

Broken High-DPI Support #53

Open mayamcdougall opened 3 years ago

mayamcdougall commented 3 years ago

Something in the theme is trying to find @2x resources when on a high DPI screen (they have @2x appended to their name).

Apparently I've never had the Inspector Console open while browsing the website with my MacBook undocked (my desk monitors are only 1080p). With the Retina screen resolution, the scripts on the site are searching for higher res versions of all the assets, which mostly don't exist.

This amounts to a large amount of script errors, depending on the page (themes, lol).

For some reason, this is also breaking the new Javascript I wrote for the Docs. I don't know enough about Javascript to know what's going on. My guess is it's just stopping execution before it gets that far or something.

Nothing on the live site seems to break from this though, it's just a lot of 404-ing and JS console errors. It could have some consequence I'm not seeing yet though.

I don't really see us supporting High-DPI assets on the current theme (since, it needs to be replaced with a Pico solution at some point anyway). My recommendation is that I should just track down the script that's trying to replace the assets and remove it for now.

(Edit: In /style/js/scripts.js, at the very start of the file is a section titled RETINA.JS which seems to be our culprit.)

Thoughts?

PhrozenByte commented 3 years ago

Thoughts?

Consider the theme as broken beyond repair :laughing:

No, seriously: I don't think that we should try to patch this theme much longer. It's totally broken. I actually like the visuals, but it lacks a lot - the galleries are kinda broken, mobile support is more or less broken, fonts and layout don't meed modern standards. Unfortunately I don't have any time for this. Before creating a new Jekyll theme I'd rather create a new Pico theme. So, if you're looking for a promising new theme to create with some visual aid (i.e. the existing one)... :wink: :heart: I'm sure I'll find a few hours to setup a CI pipeline to later push static HTML files of a Pico install to picocms.github.io.

mayamcdougall commented 3 years ago

Consider the theme as broken beyond repair 😆

I mean... yeah. 😂

How about "Any hard feelings if I just comment that script out for now?"

I agree 100% on the theme. The only reason I'm working in it now is that if I wait until I write a new theme, then that's going to overwhelm me before I get to the Docs.

Got to take it one step at a time.

Though, the Docs have been overwhelming me the last couple days, so maybe I could do with a detour. 🤔

I was experimenting a couple months ago with Bootstrap, and playing around trying to recreate bits of the current theme using it (and Pico).

I'm not 100% sold on it, but I've been getting a lot of Bootstrap experience with my other themes lately. It does do a lot of the heavy lifting for you, which is nice. I haven't tried any other frameworks yet though.

So, it's possible that the Docs rewrite never sees the current theme anyway... I just don't want to commit to too much at once. 😉

PhrozenByte commented 3 years ago

How about "Any hard feelings if I just comment that script out for now?"

Sure, go ahead, no need to ask for permission :see_no_evil: :smiley: :+1: