search

picocss / pico

Minimal CSS Framework for semantic HTML
https://picocss.com
MIT License
13.71k stars 399 forks source link

Summary in nested accordions are always styled as open #15

Closed taasan closed 3 years ago

taasan commented 3 years ago

summary should perhaps be more specific (& > summary on line 62)?

https://github.com/picocss/pico/blob/ddabc3e1ef881216e9e585705b7ffc701b26b8a8/scss/components/_accordion.scss#L60-L62

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no, viewport-fit=cover" />
    <title>Nested accordions</title>
    <link rel="stylesheet" href="https://unpkg.com/@picocss/pico@latest/css/pico.min.css" />
  </head>
  <body>
    <main>
      <article>
        <details>
          <summary>Summary</summary>
          Hello!
          <details>
            <summary>Summary always looks open</summary>
            Hello!
          </details>
        </details>
      </article>
    </main>
  </body>
</html>
lucaslarroche commented 3 years ago

Hi @taasan,

Yes you are right. I will commit a fix.

Thank you!