picocss / pico

Minimal CSS Framework for semantic HTML
https://picocss.com
MIT License
13.82k stars 406 forks source link

v2: the selected options of an unfocussed select multiple element are not readable in dark mode #434

Closed cmcaine closed 8 months ago

cmcaine commented 9 months ago

Describe the issue

In v2, the selected options of an unfocussed select multiple element are not readable in dark mode.

Current Behavior

Focused: image

Unfocused: image

Expected Behavior

To be able to read the selected options when the select element is not focused.

Reproduction URL

https://v2.picocss.com/docs/forms/select#multiple

Environment

Windows, Firefox 121.0.1

lucaslarroche commented 9 months ago

@cmcaine I couldn't see the problem on MacOS/iOS Chrome/Firefox. This light blue color is very weird 🤷‍♂️

It would be ideal if someone could help me debug/find the problem.

Brian-Pob commented 9 months ago

I did some testing on MacOS, Arch Linux, and Windows 11 (Browserstack). I was able to reproduce the issue on Windows 11 with Firefox versions 121 and 122 (latest version). I used Browserstack for some quick testing but I have access to Windows machines that I can do further testing on.

FF 121 FF 122
MacOS Did not test Not reproduced
Arch Linux Did not test Not reproduced
Windows 11 Reproduced Reproduced

Screenshot of firefox 121 on browserstack Firefox 121

Screenshot of firefox 122 on browserstack Firefox 122

lucaslarroche commented 9 months ago

Thanks @Brian-Pob!

I tried to force the color on the checked options. Could you check that this fixes the problem? https://codepen.io/lucastests/pen/NWJJNVy

Brian-Pob commented 9 months ago

That seems to have fixed it! Tested on Windows 11 on Firefox 122.0.1

https://github.com/picocss/pico/assets/29676413/b42b0f2a-2b8a-43e4-b618-7928a8570bc3

Brian-Pob commented 9 months ago

Also tested on Chrome and Edge on Windows 11. No issues found.

https://github.com/picocss/pico/assets/29676413/3aaa79f3-fa0c-47f4-8756-9b17395c4106