search

picocss / pico

Minimal CSS Framework for semantic HTML
https://picocss.com
MIT License
12.91k stars 372 forks source link

Nav item link role="button" is margined negatively #568

Open suche-cz opened 1 month ago

suche-cz commented 1 month ago

image

margin defined in: _nav.scss 52 nav li :where(a,[role=link])

maybe it should be nav li a:not([role=link]) ?

<nav>
    <ul>
        <li>Hello</li>
        <li><a href="#">Hello</a></li>
        <li><a href="#">Hello</a></li>
        <li><a href="#" role="button">Hello</a></li>
        <li><button>Hello</button></li>
    </ul>
</nav>
Sector6759 commented 3 weeks ago

I think it would be better to add margin-top: 0; to this rule: https://github.com/picocss/pico/blob/6dc6489e69cc1f22daa938ebd38c02400032428c/scss/components/_nav.scss#L64-L79

BTW this is a duplicate of https://github.com/picocss/pico/issues/496