search

picocss / pico

Minimal CSS Framework for semantic HTML
https://picocss.com
MIT License
13.49k stars 390 forks source link

RTL not working with new "group" #591

Open comatan96 opened 1 month ago

comatan96 commented 1 month ago

Please search for duplicate or closed issues first.

Describe the issue

RTL not working with new "group"

Current Behavior

For example. search button with wrong orientation: image

Expected Behavior

The search should be on the right and aligned

Reproduction URL

https://codepen.io/Matan-Cohen-the-decoder/pen/poXWzgz

Environment

Linux, latest pico, chrome Version 127.0.6533.72 (Official Build)

drmason13 commented 1 month ago

I believe this is due to use of physical properties in places like this: https://github.com/picocss/pico/blob/main/scss%2Fcomponents%2F_group.scss#L27-L36

Instead of left/right/top/bottom it should be inline-start/end/block-start/end. Corners are also possible.

I will raise a PR to fix this specifically. It is worth investigating the CSS as a whole for other uses of physical properties.