search

picocss / pico

Minimal CSS Framework for semantic HTML
https://picocss.com
MIT License
13.82k stars 406 forks source link

refactor: move nested sass declarations after non-nested declarations #596

Open nstringham opened 3 months ago

nstringham commented 3 months ago

This PR fixes #577 by reordering some sass declarations to work with the new rules for mixed declarations. See https://sass-lang.com/documentation/breaking-changes/mixed-decls for more info.

bunnymatic commented 3 months ago

Sad at the number of files that needed touching but happy that you might have uncovered the issue and solved it.

nstringham commented 3 months ago

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

tirthbodawala commented 2 months ago

This is a great PR to be honest, I was getting the same issue and was going to create the PR, but @nstringham already did it. Awesome! When do we get this?

blachawk commented 2 months ago

I'm currently using "@picocss/pico": "^2.0.6", within my npm workspace.

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

nstringham commented 2 months ago

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

You need to wait until this PR is merged.

bunnymatic commented 2 months ago

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

just a super nit. I think it's great!