search

picodotdev / alis

Arch Linux Install Script (or alis, also known as the Arch Linux executable installation guide and wiki) installs an unattended, automated and customized Arch Linux system.
https://picodotdev.github.io/alis/
GNU General Public License v3.0
823 stars 319 forks source link

added shellcheck in workflow and updated all sh files #216

Closed mfgbhatti closed 2 years ago

mfgbhatti commented 2 years ago

Hi, I have added shellcheck config and updated all sh files with respect to shellcheck. Please note that this is not any update on functionality of alis script but just recommended change by shellcheck in script. I tried to add much information about it in the file.

picodotdev commented 2 years ago

Hello @mfgbhatti, thanks for the PR, this is a nice feature to have for development and script quality.

I must review all changes and the conventions proposed by shellcheck, will take take me some time to review and give a try that all important things keep working.

mfgbhatti commented 2 years ago

No worries.

picodotdev commented 2 years ago

Merged in #220. Thanks for the PR!.