picodotdev / alis

Arch Linux Install Script (or alis, also known as the Arch Linux executable installation guide and wiki) installs an unattended, automated and customized Arch Linux system.
https://picodotdev.github.io/alis/
GNU General Public License v3.0
823 stars 319 forks source link

Wrong mount options for boot partition when BIOS_TYPE is bios #252

Closed pjones closed 7 months ago

pjones commented 8 months ago

If the /sys/firmware/efi directory doesn't exist then the BIOS_TYPE variable will be set to "bios". This results in the boot partition being formatted as ext4. However, mounting the boot partition fails due to FAT32 options being passed to mount.

This is caused by the PARTITION_OPTIONS_BOOT variable being hard-coded to contain uid, gid, fmask, and dmask options, which are not valid ext4 options.

I would suggest setting PARTITION_OPTIONS_BOOT conditionally based on BIOS_TYPE. A better option would be to not even use a boot partition when BIOS_TYPE is bios.

picodotdev commented 7 months ago

Thanks for note this.