Closed cwensley closed 4 years ago
That's incredible, thank you! As I say I have no Metal system to test with right now, so I trust your screenshot that it works. :) I appreciate the experienced eye, too; for example I wouldn't have thought to make TargetFrameworks consistent across all my .csprojs, honestly.
Some help would be...helpful, with regard to the build system and XamMac2, if I could be a pain. I've always struggled a bit with Xamarin.Mac, and someone who knows what they're doing would be welcome. I've also only done a little with CI/CD (and that using Nuke, not just plain MSBuild or .NET Core), and very little NuGet.
One final ask, if I may: is there a chance you could give my custom WPF event bubbling thing a look? Specifically WinFormsControl_MouseDown, WinFormsControl_MouseWheel, etc. It took a bit of copy/paste work to get it going to begin with, and I was never sure it was remotely correct code. The goal being to allow mouse and keyboard events to bubble properly when hosting a WinForms control. It seems to work, empirically, but I'd feel a little uncomfortable putting anything up on NuGet for the public to consume until someone could tell me whether that code is sane or not.
Hey @ItEndsWithTens, this should get things working on macOS:
I had to change the OnResize to be called during the next Draw event so it wouldn't crash when resizing the control. This appears to work on all platforms.
I also changed the .csproj's for WPF and WinForms to import Microsoft.NET.Sdk.WindowsDesktop conditionally as doing a nuget restore fails on !windows without it, which means you wouldn't be able to build on anything but windows unless you created a separate sln excluding those projects.
Thanks again for your efforts with this! It's really cool to see these controls available for Eto.Forms. Please let me know if you need help getting these published as nuget packages and/or creating the XamMac2 backend.