search

picoe / Eto

Cross platform GUI framework for desktop and mobile applications in .NET
Other
3.67k stars 333 forks source link

[Mac] use proper text alignment on arm64 #2438

Closed Miepee closed 1 year ago

Miepee commented 1 year ago

TextAlignment Right and Center are switched up on Arm64 Macos. So this PR fixes this by giving the switched up version in the ToEto/ToNS functions if the current running system is Arm.

Fixes #2250 (don't have a mac device currently, so didn't actually test).

cwensley commented 1 year ago

Thanks for the fix @Miepee!

I'm not sure if the net7.0-macos workload already deals with this so that needs to be looked into first. If it does, the fix should probably go into MonoMac instead of in Eto.

Miepee commented 1 year ago

Does the net7.0 workload use xamarin? if yes, it seems to have been merged about a year ago: https://github.com/xamarin/xamarin-macios/issues/12111

cwensley commented 1 year ago

Yes they are the same. So we should do a similar fix for the MonoMac submodule instead.

Miepee commented 1 year ago

Gotcha, will mark as ready to review then when I moved the fix to monomac.

Miepee commented 1 year ago

Guess i was too slow, sorry for that

cwensley commented 1 year ago

No worries @Miepee, I hope you didn't put too much work into it. I needed it for one of my projects so I thought I'd take a crack at it.