Make use of the virtual method `CreateControl` on wpf `DrawableHandler`

picoe / Eto

Cross platform GUI framework for desktop and mobile applications in .NET

Other

3.57k stars 325 forks source link

Make use of the virtual method `CreateControl` on wpf `DrawableHandler` #2458

Closed eng-myousif closed 1 year ago

eng-myousif commented 1 year ago

Provide a generic version of DrawableHandler to be able to provide custom control, widget and callback.
Make use of the virtual method CretaeControl when creating the wpf canvas for the drawable control.
This is required to enable the extending the drawable control when needed by a custom canvas.
That was required in our case because we needed to provide a custom automation peer for the wpf canvas. and we could only do that by providing a custom canvas to the drawable.
To make use the EtoMainCanvas I had to make it public.

eng-myousif commented 1 year ago

Hi @cwensley, For the other pull request I've noticed there go through checks like build_windows and build_mac - the third tab in the pull request - but it is not the case in my pul request. Do I need to do something from my side in that regards?

Also I would like to highlight that this pull request should help us to be able to automate some important part in our product. Hence it is so appreciated to have a look into my pull request, thanks in advance!

eng-myousif commented 1 year ago

Hi @cwensley , Thanks for merging the suggested enhancement.

I see the assigned milestone is 2.8.0 and I am expecting this will take some time to be released. Is it possible to have this enhancement in a patch release then we get it sooner as we needed asap?

cwensley commented 1 year ago

@eng-myousif absolutely, that is not a problem. I just pushed out 2.7.5. Enjoy!