picosh / pico

hacker labs - open source and managed web services leveraging SSH
https://pico.sh
MIT License
741 stars 25 forks source link

prose.sh: image URL with suffix still requires additional `ext:` options #104

Closed imcotton closed 3 months ago

imcotton commented 3 months ago

i.e.

/photo.jpg/ext:jpg

otherwise plain /photo.jpg only gives webp image.

btw: the image I uploaded was photo.jpg (with suffix).

neurosnap commented 3 months ago

Thanks for the bug report, this should be fixed now. Could you please confirm on your end?

imcotton commented 3 months ago

Thanks for the quick fix, I can confirm it's working in above cases.

One small issue I noticed with extensionless on Safari and macOS Catalina (version 10.15):

request

:method: GET
:scheme: https
:authority: bower.sh
:path: /profile
Accept: image/png,image/svg+xml,image/*;q=0.8,video/*;q=0.8,*/*;q=0.5
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.6.1 Safari/605.1.15

response

:status: 200
Content-Type: image/webp

from MDN:

[!NOTE] On Safari for macOS, WebP support depends on both Safari and macOS versions. You need Safari 14 or later as well as macOS Big Sur (11) or a more recent version. ^mdn

imcotton commented 3 months ago

@neurosnap below is screen shot taken from Safari (15.6) on macOS Catalina (10.15) for example:

Screen Shot 2024-03-24 at 6 46 22 PM