search

picozone / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

maxHieght is used instead of maxWidth #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Version of SimpleModal?
 * SimpleModal 1.3-b1 - jQuery Plugin

Version of jQuery?
 * jQuery JavaScript Library v1.3.1

Browser/OS you are experiencing the problem with?
All

In setContainerDimensions() mh is used instead of mw. With specified width
the width can incorrectly be set to the maxHeight. With no specified width
the width is set the same as the maxHeight.

Fix: replace all instances of mh with mw in the width code block. Attached
diff file is malformed but it gets the point across.

Original issue reported on code.google.com by cavi...@gmail.com on 11 Jun 2009 at 2:06

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks cavidae! I had actually found and changed the second part, but 
overlooked the
first ;)

After I get this checked in, 1.3 should be ready to go - just need to do the
documentation.

Original comment by emartin24 on 11 Jun 2009 at 3:33

GoogleCodeExporter commented 8 years ago 
Happy to help and thank you for writing this great project!

Original comment by cavi...@gmail.com on 11 Jun 2009 at 4:37