picqer / moneybird-php-client

PHP Client for Moneybird V2
MIT License
82 stars 77 forks source link

Missed attribute 'prices_are_incl_tax' for Estimate entity. #252

Open belatrix22 opened 2 years ago

belatrix22 commented 2 years ago

Hi, I'm using this library for my project. I found that entity Estimate missed attribute prices_are_incl_tax Can someone add this attribute to this Estimate parameter here: protected $fillable = [ 'id', 'administration_id', 'contact_id', 'contact', 'estimate_id', 'workflow_id', 'document_style_id', 'identity_id', 'draft_id', 'state', 'estimate_date', 'due_date', 'reference', 'language', 'currency', 'exchange_rate', 'discount', 'original_estimate_id', 'show_tax', 'sign_online', 'sent_at', 'accepted_at', 'rejected_at', 'archived_at', 'created_at', 'updated_at', 'public_view_code', 'version', 'pre_text', 'post_text', 'details', 'prices_are_incl_tax', 'total_price_excl_tax', 'total_price_excl_tax_base', 'total_price_incl_tax', 'total_price_incl_tax_base', 'total_discount', 'url', 'custom_fields', 'notes', 'attachments', 'events', 'tax_totals', ];

Or how can I do pull request for this issue.
I tried to create new branch and push it to make pull request but I don't have access rights to do it.
patrickbrouwers commented 2 years ago

I created a PR for it: https://github.com/picqer/moneybird-php-client/pull/253

arondeparon commented 2 years ago

Seems like this issue can be closed 😄