picqer / php-barcode-generator

Barcode generator in PHP that is easy to use, non-bloated and framework independent.
GNU Lesser General Public License v3.0
1.67k stars 402 forks source link

Fix failing test by throwing expected exception #75

Closed griffithben closed 4 years ago

griffithben commented 5 years ago

Running tests threw an error:

1) BarcodeTest::ean13_generator_throws_exception_if_invalid_chars_are_used
A non-numeric value encountered

/app/src/BarcodeGenerator.php:1505
/app/src/BarcodeGenerator.php:148
/app/src/BarcodeGeneratorSVG.php:21
/app/tests/BarcodeTest.php:54

Wrapped BarcodeGenerator.php:1505 to throw the proper exception.

casperbakker commented 4 years ago

Should be fixed by #80