picqer / picqer-php

PHP Client for the Picqer API
https://picqer.com/en/api
MIT License
18 stars 23 forks source link

Add filter option to purchaseOrders #10

Closed barryvdh closed 6 years ago

barryvdh commented 6 years ago

This is available according to the documentation. This also makes it work with $api->getAllResults('purchaseorder', ["status" => "purchased"]);

barryvdh commented 6 years ago

Oh, I now realise that when the $filters are not passed, you will also not set the offset. So it keeps on getting the same result with getAllResults. Perhaps a check should be added to ensure only functions are called that support pagination (or check all methods to add pagination in the API)

casperbakker commented 6 years ago

Thanks @barryvdh