picselliahq / picsellia-training-engine

MIT License
2 stars 0 forks source link

first draft of unet training script #20

Closed hajeressef closed 1 year ago

hajeressef commented 1 year ago

PR to add training script of Unet architecture for instance segmentation. The abstract_trainer used can be found in this PR

This is a sample experiment for a unet experiment on picsellia.

picsalex commented 1 year ago

Thanks for the PR @hajeressef ! Some details I've noticed on the structure:

hajeressef commented 1 year ago

Hi @picsalex . Thank you so much for your feedback.

picsalex commented 1 year ago
hajeressef commented 1 year ago
  1. We could perhaps keep the old ones for now with the old naming, and slowly clean up/delete the "captured" repos as they get reworked/refactored into new repos with new names.
  2. no I believe we need it to be pushed. The idea is that whoever pulls this repo to experiment more or test without a docker image, can use this poetry file in their environment
  3. Makes sense. I will move it to root directory as you mentioned.
picsalex commented 1 year ago
PN-picsell commented 1 year ago

Looks really nice to me, @picsalex @hajeressef we can meet online to discuss the matters adressed here. Just one think before we merge, can you update the notebook so it looks exactly like the main.py file ? This way it's clear where to start the research back