picselliahq / picsellia-training-engine

MIT License
2 stars 0 forks source link

Fix: adapt logs handler to jobs #34

Closed SoniaGrh closed 11 months ago

SoniaGrh commented 11 months ago
picsalex commented 11 months ago

I would personally slightly change the folder hierarchy for the base/ folder, something like :

base/
|-- logs/
|   |-- __init__.py
|   |-- handler.py (previously logs_handler.py)
|   |-- monitor.py (previously log_monitor.py)
|   |-- tailer.py (previously log_tailer.py)
|
|-- utils/
|   |-- __init__.py
|   |-- picsellia.py (i guess this should conflict with the picsellia package by calling utils.picsellia)
SoniaGrh commented 11 months ago

I would personally slightly change the folder hierarchy for the base/ folder, something like :

base/
|-- logs/
|   |-- __init__.py
|   |-- handler.py (previously logs_handler.py)
|   |-- monitor.py (previously log_monitor.py)
|   |-- tailer.py (previously log_tailer.py)
|
|-- utils/
|   |-- __init__.py
|   |-- picsellia.py (i guess this should conflict with the picsellia package by calling utils.picsellia)

The folder "utils" was also conflicting with the utils folder/file of training images, should I replace it with

|-- base_utils/ | |-- init.py | |-- picsellia_utils.py

Or do you have a better suggestion ?