search

picturae / openseadragonselection

An OpenSeadragon selection plugin for the tiled viewer.
Apache License 2.0
50 stars 24 forks source link

Selection confirm and cancel labels are always the same #41

Closed gjactat closed 5 years ago

gjactat commented 5 years ago

Hello, I've noticed that the titles of the two buttons displayed over the selection (confirm/cancel) are always the same, despite being properly initialized with distinct values.

This problem can be observed on the test page (both buttons have th 'Ok' label) : https://picturae.github.io/openseadragonselection/

MindFreeze commented 5 years ago

On the demo page only the 'confirm' button has a specified tooltip with OpenSeadragon.setString('Tooltips.SelectionConfirm','Ok');

gjactat commented 5 years ago

Thanks for your reply. I've built a quick minimalist CodePen to show you what happens when you specify both "SelectionConfirm" and "SelectionCancel". As you can see, both buttons get the same label eventually : https://codepen.io/gjactat/pen/NoaPbm

MindFreeze commented 5 years ago

I see the problem. The minified version in /dist was built from very old code. I just compiled it with the latest changes so it works now. Just remember to clear your cache.

gjactat commented 5 years ago

Thanks ! One more question : Is there an official npm package of this plugin ? The one I use was updated 2 years ago... https://www.npmjs.com/package/openseadragonselection