search

picturepan2 / spectre

Spectre.css - A Lightweight, Responsive and Modern CSS Framework
https://picturepan2.github.io/spectre/
MIT License
11.31k stars 804 forks source link

Fixed deprecated rules in sass 2.0 & updated dependencies #685

Open Valexr opened 2 years ago

Valexr commented 2 years ago

sass-migrator division */.scss

Valexr commented 2 years ago

$version in src/_variables.scss misses a 0

fixed

NazimHAli commented 2 years ago

Can this be merged?

janbakker2525 commented 2 years ago

Yes (but I do not have write access)

salamwaddah commented 1 year ago

@jviotti do you have write access?

jviotti commented 1 year ago

I do not, sorry @salamwaddah

blokhin commented 1 year ago

Dear @codebling please, would you mind accepting :pray:

codebling commented 1 year ago

@blokhin why are you tagging me?? I don't have any access to this repo

codebling commented 1 year ago

I've approved, in case that helps.

blokhin commented 1 year ago

Ah, sorry, I've thought you might have the necessary rights. Unfortunately, the repo author Yan Zhu @picturepan2 does not respond for almost a year.

codebling commented 1 year ago

That's unfortunate. Perhaps time for a fork?

peterhil commented 1 year ago

There is a SpectreCSS organisation, made by @picturepan2: https://github.com/picturepan2/spectre/issues/684#issuecomment-991630756

Ping: @codebling @jviotti @devmount

I really wish to continue using Spectre.css, and I am willing to contribute to it’s development.

codebling commented 1 year ago

@peterhil are you tagging me because you want me to move the repo? I have no access to this repo.

Nobody except picturepan2 has access to this repo, as far as I can tell, and they have not been responsive to @ mentions in this repo for quite some time. The good news is, it's open source. I suggest someone fork (possibly into the org you mentioned) and add others as admins to the repo.

davestewart commented 9 months ago

To everyone who needs this, you can just do:

npm i Valexr/spectre

No other changes needed.

@Valexr - in lieu of someone creating a new repo and merging all the pending PRs, will you keep your repo up?

Valexr commented 9 months ago

To everyone who needs this, you can just do:

npm i Valexr/spectre

No other changes needed.

@Valexr - in lieu of someone creating a new repo and merging all the pending PRs, will you keep your repo up?

I don't think so... @davestewart , there's no time to do it. I did it exclusively for a project that I don't support anymore.

davestewart commented 9 months ago

Ok, thanks for the info. I'll fork!

ma4nn commented 9 months ago

I am using spectre.css in my projects a lot and really love its simplicity. So sad there is no solution to continue it within the current repo/setup/org.

In case there is any interest I would be willing to continue maintaining a fork for it. I have merged the code changes from @Valexr into my fork vianetz/spectre-css and will create copies of other pull requests from the main repo that makes sense to me.

In addition I have setup Github Actions to automatically run the build process and added an action to automatically deploy the docs to https://vianetz.github.io/spectre-css/.

Let me know your input, I'm happy to merge more pull request proposals if they make sense.

davestewart commented 9 months ago

Yeah, I think it's about time.

I created an organisation called Picturepan Too (see what I did there?)

I figure this could be more neutral than a single developer having to take ownership.

I'm happy to add those who want to step up, or could just delete if it's deemed too complicated.

Would be good then to:

Later improvements might include:

Thoughts? Suggestions?

EDIT: I created a discussion here.

niutech commented 3 months ago

This PR has been merged into my updated fork of Spectre 0.6.0.

peterhil commented 3 months ago

There is also spectre-org/spectre-css, but it’s updated some months ago, unlike niutech’s fork which is updated a few days ago.

niutech commented 3 months ago

spectre-org/spectre-css 1.0.0. is based on 0.5.9 and update to 0.5.10 is yet to be done, whereas my fork is based on 0.5.10 with some updates, e.g. I am working on pure CSS tabs.

Ideally there should be a single community-driven up-to-date repo of Spectre, but it seems spectre-org/spectre-css development has stalled. Any updates @davestewart?

davestewart commented 3 months ago

Hey @niutech,

Thanks for the mention.

Yes, development has stalled; I got really busy last year and after releasing the new docs and site I didn't have much more time.

However, an interesting development from literally yesterday is that @picturepan2 followed me on Twitter so I sent him a message to bring him up to speed. Without pasting the bulk of the message, I ended with this:

Regarding going forwards, I guess the main questions are:

  • do you have or want to donate any time to spectre going forward?
  • are you interested in working with collaborators?
  • what are your thoughts on spectre.org?

I can see various routes:

  • effort moves more towards spectre.org; you come onboard in some capacity, (even just to validate the project, but hopefully more)
  • the new repos move towards you; I wouldn't be averse to donating the new docs repo if spectre under @picturepan2 had a future
  • you say you're not interested in the project anymore, and it's up to me to figure out where to go next
  • you're not happy with any of it, I guess then, you tell me where you're at!

I can actually find the time in the next few weeks / months to put some effort in.

I'd like to – at least help – get Spectre to a stage where it can live on for another few years, and it would be great if that was more of a community effort.

Watch this space; I'll certainly feed back on this thread, and hopefully there'll be some input from @picturepan2 as well.

And regards the .5.9 and .5.10 branches; unfortunately this PR messed with button margins, and I never had the time to correct this. At least, this is what the docs site shows. How did your merge go? Are the button margins OK?

If yours works correctly, I would be totally happy to re-merge a better version into the new core.

Cheers, Dave

niutech commented 3 months ago

@davestewart It would be great if you could devote your time to developing Spectre in the coming months. I'd try to submit some PR when I finish my work in progress.

As for buttons, they look OK in my fork: https://niutech.github.io/spectre/elements/buttons.html Problem with your docs site is that it lacks space characters between <button>s due to HTML minification.

EDIT: I've implemented pure CSS tabs in my fork.

davestewart commented 3 months ago

Problem with your docs site is that it lacks space characters between <button>s due to HTML minification

OMG that's stung me before!!! That's for noticing that; at least I can solve that now 🙏

EDIT: I've implemented pure CSS tabs in my fork.

Do you want to create an issue to discuss on spectre-org?

davestewart commented 3 months ago

OK, the margin issues I mentioned above have now been fixed in the spectre-org docs so I now consider this PR properly merged in spectre-org/spectre-css 🎉