search

picuscreative / testcafe-reporter-html

The HTML reporter for TestCafe
https://picuscreative.com/
22 stars 30 forks source link

HTML tags are not esacped in error details #14

Closed janrozycki closed 5 years ago

janrozycki commented 5 years ago

I'm using TestCafe with TypeScrpt and I noticed that in some cases errors from TestCafe are cointaining type definitions which are treated by browser as opening HTML tag. Fo example: let myArray: Array<object> = []; This also affects a stacktrace present in an error, which sometimes contains lines similar to the one below: at MyClass.<anonymous> (C:\Path\to\file.ts) This causes that errors displayed in the browser are not 100% correct and entire HTML structure is jumbled (as some browsers are automatically closing unclosed tags at the end of a DOM structure)

timnederhoff commented 5 years ago

Did a PR #15 that include escaping the error code for html (+ curly braces { })

davidcunha commented 5 years ago

Awesome, thanks @timnederhoff ✌️