picuscreative / testcafe-reporter-html

The HTML reporter for TestCafe
https://picuscreative.com/
22 stars 30 forks source link

Upgrade few dependencies and fix test, lint errors #25

Closed rmkanda closed 4 years ago

rmkanda commented 4 years ago
IAmJoffa commented 4 years ago

@rmkanda I was going to make a similar set of changes to this and have reviewed them and they look fine. Does anyone @github.com/picuscreative/testcafe-reporter-html have time to review this or provide feedback on how to get this PR merged in?

rmkanda commented 4 years ago

Thanks @IAmJoffa

@davidcunha @timnederhoff @ruirochawork @paazmaya @BrunoLima18 @ricardoparente @ruirochawork Could you please merge it...

timnederhoff commented 4 years ago

If I could I would :smile:

timnederhoff commented 4 years ago

@davidcunha @ruirochawork @tayay do you have permissions to merge? please respond. @PicusCreative it is very cool you have the 'html' name as the best suited name for the html reporter of testcafe, but please make use of it!

rmkanda commented 4 years ago

Thanks @spRite75 Could you please also merge it.

spRite75 commented 4 years ago

@rmkanda I'm not a collaborator, I just also would like this merged and don't know how else to raise visibility of this. Sorry!

timnederhoff commented 4 years ago

Thanks @ruirochawork for adding me as collaborator +1

rmkanda commented 4 years ago

Thanks @timnederhoff @ruirochawork

rmkanda commented 4 years ago

@timnederhoff Is it possible to make a new release with the fix?

timnederhoff commented 4 years ago

@rmkanda sure, I created a new release in Github (and tagged it 1.4.5). But I don't have a place to publish it since I don't have permission to publish it to npmjs.com under the testcafe-reporter-html package name (@ruirochawork could you maybe publish on npmjs.com? or give me permissions?). meanwhile, I published it temporarily under my name: https://www.npmjs.com/package/@timnederhoff/testcafe-reporter-html

rmkanda commented 4 years ago

Thanks @timnederhoff

timnederhoff commented 4 years ago

@davidcunha you were the last one to publish the release on npmjs.com, could you do this for v1.4.5 too? or ad me as a maintainer in npmjs.com?

davidcunha commented 4 years ago

@timnederhoff I added you in npm!

timnederhoff commented 4 years ago

Thanks David, @rmkanda FYI, I published the 1.4.5 version under testcafe-reporter-html name now. the @timnederhoff/restcafe-reporter-html will be deprecated

rmkanda commented 4 years ago

Thanks @timnederhoff @davidcunha