picuscreative / testcafe-reporter-html

The HTML reporter for TestCafe
https://picuscreative.com/
22 stars 30 forks source link

Dependencies should be devDependencies #29

Closed richard-codecontrol closed 4 years ago

richard-codecontrol commented 4 years ago

Hi,

When using the reporter in my project the dependencies in that project explode because of all the dependencies that come with the testcafe-reporter-html package. One such example is eslint. From my own project:

yarn why v1.19.1
[1/4] πŸ€”  Why do we have the module "eslint"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] πŸ”  Finding dependency...
[4/4] 🚑  Calculating file sizes...
=> Found "eslint@6.7.2"
info Reasons this module exists
   - "testcafe-reporter-html#gulp-eslint" depends on it
   - Hoisted from "testcafe-reporter-html#gulp-eslint#eslint"
info Disk size without dependencies: "4.18MB"
info Disk size with unique dependencies: "14.73MB"
info Disk size with transitive dependencies: "36.93MB"
info Number of shared dependencies: 74

Upon inspection I noticed that none of the dependencies in the package are runtime dependencies. So I made PR #28 that moves all non-runtime dependencies to devDependency. Therefore they won't be included when using the package in another project. Travis build has run successfully and successfully tested it with my local Testcafe project.