search

picuscreative / testcafe-reporter-html

The HTML reporter for TestCafe
https://picuscreative.com/
22 stars 30 forks source link

Added CSS properties #30

Closed daemon-selvarajan closed 4 years ago

daemon-selvarajan commented 4 years ago

Hello Team,

Added CSS properties for the html report. Please review & approve the request

Thanks, Selvarajan

timnederhoff commented 4 years ago

Hi Selvarajan, can you adjust the test to have it pass?

daemon-selvarajan commented 4 years ago

Hey Timnederhoff, yeah sure. BTW, could you please point me which file do you want me to add test ?

timnederhoff commented 4 years ago

you can edit the /test/data/report-with-colors.html file according to your expected html code. You can run the preview to see how the output file would look like

timnederhoff commented 4 years ago

Hi @daemon-selvarajan, I see the shadows have similar color now, looks better to me indeed. The test (npm test) runs the html report with testdata and compares the resulting html code with the expected html in test/data/actual.html. At the moment, these contents don't match. I suggest you run gulp preview and review the html report generated in the your terminal. If that's the desired result, you can use that code to set the contents of test/data/actual.html

daemon-selvarajan commented 4 years ago

Thanks a lot, @timnederhoff for the brief explanation.

Changed the expected HTML as well as the index.js to have the shadow to 6px.

Please find below report for npm test run : PASS

selvarajan@Autos-MacBook-Pro testcafe-reporter-html % npm test

> testcafe-reporter-html@1.4.5 test /Users/selvarajan/PycharmProjects/Open-Source-Contributions/testcafe-reporter-html
> cross-env NODE_ENV=test gulp build && cross-env NODE_ENV=test gulp test

[16:54:06] Using gulpfile ~/PycharmProjects/Open-Source-Contributions/testcafe-reporter-html/gulpfile.js
[16:54:06] Starting 'build'...
[16:54:06] Starting 'clean'...
[16:54:06] Finished 'clean' after 8.08 ms
[16:54:06] Starting '<anonymous>'...
[16:54:06] Finished '<anonymous>' after 345 ms
[16:54:06] Finished 'build' after 355 ms
[16:54:07] Using gulpfile ~/PycharmProjects/Open-Source-Contributions/testcafe-reporter-html/gulpfile.js
[16:54:07] Starting 'test'...

  ✓ Should produce report with colors (39ms)

  1 passing (42ms)

[16:54:07] Finished 'test' after 320 ms
selvarajan@Autos-MacBook-Pro testcafe-reporter-html %

Kindly please approve.

Thanks bunch, Selvarajan