search

pid / speakingurl

Generate a slug – transliteration with a lot of options
http://pid.github.io/speakingurl/
BSD 3-Clause "New" or "Revised" License
1.12k stars 84 forks source link

How To Add Georgian Language Support? #92

Closed vdanelia closed 7 years ago

vdanelia commented 7 years ago

Hello how to add Georgian Language in "Speakingurl"?

pid commented 7 years ago

https://en.m.wikipedia.org/wiki/Romanization_of_Georgian ISO 9984

The transliteration table has to be added to speakingurl

If you can send a pull request, we can quickly release a new version ;-) otherwise you have to wait, Eventually I can take a look into this at the weekend

pid commented 7 years ago

@vdanelia Take a look in lib/speakingurl.js

vdanelia commented 7 years ago

ok I found it... i'll add Georgian .... :)

Why to use ISO 9984-(1996) it seems to old ... we use here National system-(2002) more simple variant and easy to guess. ISO 9984-(1996) uses other symbols like: ž, ḡ, š, č, j, .. we use: zh, gh, sh, ch, dz.... etc. What if I use National system-(2002) instead of ISO 9984-(1996)?

vdanelia commented 7 years ago

:+1:

henryruhs commented 7 years ago

I suggest to use the latest ISO and not to wait for @pid to respond. Just send the pull request.

@pid What about a playground / demo for contributors with a input and output field?

vdanelia commented 7 years ago

hello @redaxmedia ... ISO 9984-(1996) is very strange standard, no one uses that, no one site or person... because it consists with non georgian symblos (characters)... so I'll do National system-(2002)..

on National System-(2002) based our International Passports, Street Names, Geographical Names.. Map. I haven't seen ISO Standard used In Georgia

vdanelia commented 7 years ago

I'm finishing it and will make pull request today or tomorrow... 👍

henryruhs commented 7 years ago

You did something wrong, I commented the pull request.

pid commented 7 years ago

@redaxmedia please run "gulp" before you commit, this will beautify your files, runs the test, you added test? 😉 .... so the formating will be unique

henryruhs commented 7 years ago

Well, it is not me - it is @vdanelia who sends the pull request ... I guess he doesn't know how to run gulp

pid commented 7 years ago

V12.0.0 is released, with Support for Georgian

henryruhs commented 7 years ago

Great move! Thank you

vdanelia commented 7 years ago

Perfect... Greatest Thanks