piderman314 / bardecoder

Detect and decode QR Codes, written in 100% Rust.
MIT License
272 stars 34 forks source link

Is this a mistake/misspell? #41

Closed mrg0lden closed 2 years ago

mrg0lden commented 2 years ago

Hi, I have been going through the source code for a few days, and here I found that left and right are essentially the same values. So, I wondered if it should have been something else.

https://github.com/piderman314/bardecoder/blob/a8cbe330fc203660a7ff024b8867f8e04b2ea05a/src/extract/qr/mod.rs#L358

piderman314 commented 2 years ago

Whoops, that's a typo. Well spotted.

mrg0lden commented 2 years ago

Since you have responded, I want to take the chance to ask you about the algorithms used. Is there any reference I can use to better understand what is going on? If not, do you mind giving a brief explanation of how things work?

Thank you.

piderman314 commented 2 years ago

For the most part I used the information in the QR standard which is available under ISO 18004.