Best lending protocol oracle

MickdeGraaf commented 3 years ago

For a given underlying asset it returns the APR and which lending protocol has the best rate

User Story

As an <audience/user>: Dev
I want to <action/task>: Have a single interface to determine the best protocol to lend an asset in
so that <outcome/goal/benefit>: Can easily create automated yield bouncing strategies

Type

[x] Enhancement
[ ] Maintenance
[ ] Refactor

Description

Add a function to the lendingRegistry which returns the highest APR for a given _underlying and array of _protocols with the following interface:

getBestApr(address _underlying, bytes[] memory _protocols) external view returns(uint256 apr, bytes32 protocol);

Definition of Done

[ ] Implemented
[ ] Tested

Relies on #17

Evert0x commented 3 years ago

it is appropriate to implement both getBestApr and getBestAprView? In relation to the underlying lending logic methods

Evert0x commented 3 years ago

Implemented in feature/best-apr, included the changes from #17 and #18

pie-dao / PieVaults