pie-dao / btc.piedao.org

3 stars 3 forks source link

[Feature] i18n support #15

Closed dmvt closed 4 years ago

dmvt commented 4 years ago

User Story

Type

Description

We have a global user base. We should be friendly to them.

Solution

@nigeon has a great first pass at https://github.com/pie-dao/btc.piedao.org/pull/4. Unfortunately, the approach taken does not fully support the modular approach of @pie-dao packages. The translations are great, but the text object passed down through the React props (https://github.com/pie-dao/btc.piedao.org/blob/development/src/index.jsx#L54) should be maintained and configured by the i18n solution.

After reviewing the various options, I believe i18next is the right library to use (https://www.i18next.com/overview/getting-started). If you would prefer to use another, please discuss it in the comments on this issue.

Definition of Done

Attach files or screenshots if it's helpful for this issue.

nigeon commented 4 years ago

Is there any bounty program?