WIP: adding joinswapExternAmountIn modal

pie-dao / pools.piedao.org

pools-piedao-org-flax.vercel.app

Other

24 stars 27 forks source link

WIP: adding joinswapExternAmountIn modal #299

Closed benbot closed 2 years ago

benbot commented 2 years ago

Description

Add joinswapExternAmountIn modal on PieindexLanding

Checklist

[ ] Linter status: 100% pass
[ ] Changes don't break existing behavior
[ ] Test coverage hasn't decreased

Testing

None atm, not working

netlify[bot] commented 2 years ago

👷 Deploy request for nightly-pools-piedao accepted.

🔨 Explore the source changes: 907cc8c53ad5dc536a0880a5e56c3eefe893bdc1

🔍 Inspect the deploy log: https://app.netlify.com/sites/nightly-pools-piedao/deploys/6215ae9e9b22960007ba486b

benbot commented 2 years ago

Having an issue converting the quote.value into an ethers.BigNumber. I keep seeing underflow errors in the console.

Weird part is, if I add a breakpoint just before the offending line (300 in PieIndexLanding.svelte) and try converting quote.value into a BigNumber from the console, it seems to work fine.

Any help fixing that would be greatly appreciated.

Alexintosh commented 2 years ago

Answered in DM

benbot commented 2 years ago

some more updates

Untangled a lot of the joinSwap component.

As i said in the commit message, hopefully we can use it as a base for a reusable, generic Swap component.

There's still some issues getting the static call working and some dev artifacts to clean up before it's good to really review..