search

pie-dao / pools.piedao.org

pools-piedao-org-flax.vercel.app
Other
25 stars 27 forks source link

remove get store inside getPoolsUser #325

Open gbonumore opened 2 years ago

gbonumore commented 2 years ago
Description

Removed get eth from store since it is already available inside as a reactive value in order to prevent signer / provider from being undefined

jordaniza commented 2 years ago

I don't understand why this fixes the problem. The removed code looks like it should work. What was the issue with calling get(eth)?

gbonumore commented 2 years ago

I don't understand why this fixes the problem. The removed code looks like it should work. What was the issue with calling get(eth)?

getPoolsUser gets called when eth is not defined so destructing it throws undefined on those values while using directly those from the store are already nullchecked. Also get(eth) is totally unnecessary since with $eth we can directly access a reactive store value.