search

pie-framework / pie-elements

A collection of pies for rendering interactions in an assessment environment
http://pie-website.surge.sh
ISC License
0 stars 7 forks source link

Tables in existing PMLC questions migrated to PIE don't show in the PIE editor #48

Closed PowerMyLearningConnect closed 6 years ago

PowerMyLearningConnect commented 6 years ago

Tables in existing PMLC questions migrated to PIE don't show in the PIE editor, thought it renders in the preview section (on the right). http://sbox.powermylearning.org/piedemo/MultipleChoice_Table_Example.html https://github.com/paritoshcardinal/pie_elements_demo/blob/master/mc/table.json

image010

@edeustace @elodszopos @narayankj

elodszopos commented 6 years ago

@edeustace Once again, I looked into this and I can confirm that the serialization logic is stripping off the table related tags for some reason. The markup prop contains the correct value but upon serializing and parsing back into usable format, the tags disappear.

Relevant lines of code are in the editable-html constructor, src/index.js, around lines 25-35.

edeustace commented 6 years ago

@narayankj, this relates to slatejs core schema rules. We'd have to update the schema.

edeustace commented 6 years ago

There is a plugin for table support will check it out.

edeustace commented 6 years ago

I have begun to add support for this - note that full table editing support may have to be pushed out to another issue and for now we set up table rendering.

PowerMyLearningConnect commented 6 years ago

Closing since partial support has been released.