piebro / openstreetmap-statistics

Monthly updated interactive statistics about OpenStreetMap.
https://piebro.github.io/openstreetmap-statistics/
MIT License
34 stars 6 forks source link

data update #18

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

update plots and tables with the latest changeset

matkoniecz commented 1 year ago

note that now it tracks also changes in private forks (for example UniversalSurfaceOverlay is from testing https://github.com/streetcomplete/StreetComplete/pull/4642 )

piebro commented 1 year ago

The script adds all changesets that use the StreetComplete:quest_type tag. Maybe private forks can be filtered out also using the created_by. Do private forks in gereral use another created_by tag?

matkoniecz commented 1 year ago

Do private forks in gereral use another created_by tag?

Depends whether they changed it, for example test edits made by in-development version would not have it changed.

For example my fork is using custom created_by - https://www.openstreetmap.org/changeset/129128180

piebro commented 1 year ago

That makes sense. I think then there are two ways to handle it.

  1. hard code a list of all official quest types. This would need to be updated regularly (more maintenance)
  2. filter out custom forks that use other an other created_by tag. (less precision)

I'm slightly in favor of option 2, but both options are fine I think.

matkoniecz commented 1 year ago

This would need to be updated regularly (more maintenance)

Or read it from lists in SC code, but that also can be fragile

filter out custom forks that use other an other created_by tag. (less precision)

sounds good enough, maybe put also note in the bottom and link https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt and https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/overlays/OverlaysModule.kt ?