piece / makegood

A continuous test runner for Eclipse PDT
https://github.com/piece/makegood/wiki
44 stars 17 forks source link

Error running makegood in eclipse luna #59

Closed maruhgar closed 10 years ago

maruhgar commented 10 years ago

I get the attached error trying to run phpunit test using makegood on Eclipse Luna.
2014-06-26 15_21_30-php - eclipse Makegood version: 3.3.0 Php version: 5.5.12 PHP Development Tools (PDT) 3.3.0.201406110111 phpunit version: 4.1.3 Set up using composer.json and vendor folder Stacktrace in .log file

!MESSAGE An internal error occurred during: "Launching MemberRegistrationTest".
!STACK 0
java.lang.NoClassDefFoundError: org/eclipse/osgi/framework/debug/Debug
    at com.piece_framework.makegood.launch.CommandLineBuilder.build(CommandLineBuilder.java:142)
    at com.piece_framework.makegood.launch.MakeGoodLaunchConfigurationDelegate.createConfiguration(MakeGoodLaunchConfigurationDelegate.java:261)
    at com.piece_framework.makegood.launch.MakeGoodLaunchConfigurationDelegate.getLaunch(MakeGoodLaunchConfigurationDelegate.java:85)
    at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:812)
    at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
    at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1039)
    at org.eclipse.debug.internal.ui.DebugUIPlugin$8.run(DebugUIPlugin.java:1256)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: java.lang.ClassNotFoundException: org.eclipse.osgi.framework.debug.Debug cannot be found by com.piece_framework.makegood.launch_3.0.0.v201406100541
    at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:423)
    at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:336)
    at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:328)
    at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
    ... 8 more
iteman commented 10 years ago

MakeGood 3.0.0 does not support Eclipse Luna. It will be supported in MakeGood 3.1.0. MakeGood 3.1.0 will be released soon.

Referecnes: #59, #60, #62

Archanciel commented 10 years ago

I get exactly the same problem with MakeGood 3.1.0, Eclipse for PHP developers, Luna release 4.4.0, PHP 5.4, PHPUnit 4.1.3 installed with Composer.

I work under Windows 8.1 x64.

capture118 capture119 capture120

jingyulee commented 10 years ago

I also have the same error screen shot 2014-07-18 at 12 38 58 screen shot 2014-07-18 at 12 39 08

Schleuse commented 10 years ago

I've got the same problem opening the Settings Page. I'm running Eclipse Luna 4.4 on Java 8u11 on Windows 7 x64.

Here's a StackTrace:

java.lang.ClassNotFoundException: An error occurred while automatically activating bundle com.piece_framework.makegood.ui (576).
  at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:116)
  at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:531)
  at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:324)
  at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:311)
  at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:386)
  at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:336)
  at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:328)
  at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160)
  at java.lang.ClassLoader.loadClass(Unknown Source)
  at org.eclipse.osgi.internal.framework.EquinoxBundle.loadClass(EquinoxBundle.java:568)
  at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:174)
  at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:905)
  at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
  at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:55)
  at org.eclipse.ui.internal.util.Util.safeLoadExecutableExtension(Util.java:873)
  at org.eclipse.ui.internal.menus.CompatibilityWorkbenchWindowControlContribution.construct(CompatibilityWorkbenchWindowControlContribution.java:54)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
  at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:888)
  at org.eclipse.e4.core.internal.di.InjectorImpl.inject(InjectorImpl.java:120)
  at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:337)
  at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:271)
  at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:186)
  at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:107)
  at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:73)
  at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:50)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolControlContribution.createControl(ToolControlContribution.java:65)
  at org.eclipse.jface.action.ControlContribution.fill(ControlContribution.java:101)
  at org.eclipse.jface.action.ToolBarManager.update(ToolBarManager.java:365)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer$3.handleEvent(ToolBarManagerRenderer.java:205)
  at org.eclipse.e4.ui.services.internal.events.UIEventHandler$1.run(UIEventHandler.java:40)
  at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:187)
  at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:156)
  at org.eclipse.swt.widgets.Display.syncExec(Display.java:4734)
  at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:218)
  at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:36)
  at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
  at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
  at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
  at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
  at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
  at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
  at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
  at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
  at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:81)
  at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59)
  at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
  at org.eclipse.e4.ui.model.application.ui.impl.UIElementImpl.setVisible(UIElementImpl.java:345)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarContributionRecord.updateVisibility(ToolBarContributionRecord.java:73)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer$10.changed(ToolBarManagerRenderer.java:510)
  at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:110)
  at org.eclipse.e4.core.internal.contexts.EclipseContext.runAndTrack(EclipseContext.java:319)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processAddition(ToolBarManagerRenderer.java:502)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.generateContributions(ToolBarManagerRenderer.java:471)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processContribution(ToolBarManagerRenderer.java:430)
  at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.createWidget(ToolBarManagerRenderer.java:391)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:983)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:662)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:766)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:737)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:731)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:715)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.handleEvent(PartRenderingEngine.java:289)
  at org.eclipse.e4.ui.services.internal.events.UIEventHandler$1.run(UIEventHandler.java:40)
  at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:187)
  at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:156)
  at org.eclipse.swt.widgets.Display.syncExec(Display.java:4734)
  at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:218)
  at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:36)
  at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197)
  at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197)
  at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)
  at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
  at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
  at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135)
  at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78)
  at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39)
  at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:81)
  at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59)
  at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374)
  at org.eclipse.emf.ecore.util.EcoreEList.dispatchNotification(EcoreEList.java:249)
  at org.eclipse.emf.common.notify.impl.NotifyingListImpl.addUnique(NotifyingListImpl.java:356)
  at org.eclipse.emf.common.util.AbstractEList.add(AbstractEList.java:341)
  at org.eclipse.e4.ui.internal.workbench.ContributionsAnalyzer.processAddition(ContributionsAnalyzer.java:369)
  at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarRenderer.addTrimContributions(TrimBarRenderer.java:194)
  at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarRenderer.processContents(TrimBarRenderer.java:166)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:674)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$6.run(PartRenderingEngine.java:547)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:531)
  at org.eclipse.e4.ui.workbench.renderers.swt.WBWRenderer.processContents(WBWRenderer.java:687)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:674)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:766)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:737)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:731)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:715)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1078)
  at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
  at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
  at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
  at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
  at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
  at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
  at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
  at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
  at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
  at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
  at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
  at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:236)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
  at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
  at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
  at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Caused by: org.osgi.framework.BundleException: Exception in com.piece_framework.makegood.ui.Activator.start() of bundle com.piece_framework.makegood.ui.
  at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:792)
  at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:721)
  at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:936)
  at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:319)
  at org.eclipse.osgi.container.Module.doStart(Module.java:571)
  at org.eclipse.osgi.container.Module.start(Module.java:439)
  at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:454)
  at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:107)
  ... 122 more
Caused by: java.lang.RuntimeException: java.io.IOException: invalid constant type: 15
  at javassist.CtClassType.getClassFile2(CtClassType.java:203)
  at javassist.CtClassType.subtypeOf(CtClassType.java:303)
  at javassist.bytecode.stackmap.TypeData$TypeName.update(TypeData.java:274)
  at javassist.bytecode.stackmap.TypeData$TypeName.setType(TypeData.java:203)
  at javassist.bytecode.stackmap.TypeData.setType(TypeData.java:46)
  at javassist.bytecode.stackmap.Tracer.checkParamTypes(Tracer.java:908)
  at javassist.bytecode.stackmap.Tracer.doInvokeMethod(Tracer.java:813)
  at javassist.bytecode.stackmap.Tracer.doOpcode148_201(Tracer.java:615)
  at javassist.bytecode.stackmap.Tracer.doOpcode(Tracer.java:101)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:161)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:120)
  at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:96)
  at javassist.bytecode.MethodInfo.rebuildStackMap(MethodInfo.java:404)
  at javassist.bytecode.MethodInfo.rebuildStackMapIf6(MethodInfo.java:389)
  at javassist.expr.ExprEditor.doit(ExprEditor.java:112)
  at javassist.CtBehavior.instrument(CtBehavior.java:659)
  at com.piece_framework.makegood.aspect.org.eclipse.php.core.aspect.SystemIncludePathAspect.weaveIntoPHPSearchEngine(SystemIncludePathAspect.java:78)
  at com.piece_framework.makegood.aspect.org.eclipse.php.core.aspect.SystemIncludePathAspect.doWeave(SystemIncludePathAspect.java:51)
  at com.piece_framework.makegood.aspect.Aspect.weave(Aspect.java:28)
  at com.piece_framework.makegood.aspect.AspectWeaver.weaveAspects(AspectWeaver.java:119)
  at com.piece_framework.makegood.aspect.AspectWeaver.weave(AspectWeaver.java:55)
  at com.piece_framework.makegood.ui.Activator.start(Activator.java:43)
  at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:771)
  at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1)
  at java.security.AccessController.doPrivileged(Native Method)
  at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:764)
  ... 129 more
Caused by: java.io.IOException: invalid constant type: 15
  at javassist.bytecode.ConstPool.readOne(ConstPool.java:1027)
  at javassist.bytecode.ConstPool.read(ConstPool.java:970)
  at javassist.bytecode.ConstPool.<init>(ConstPool.java:127)
  at javassist.bytecode.ClassFile.read(ClassFile.java:716)
  at javassist.bytecode.ClassFile.<init>(ClassFile.java:103)
  at javassist.CtClassType.getClassFile2(CtClassType.java:190)
  ... 159 more

More information on this problem:

http://www.symphonious.net/2014/03/21/javassist-java-8-invalid-constant-type-15/

Schleuse commented 10 years ago

I've got a workaround for the problem:

I replaced the javaassist 3.11.0 dependency with the newest javaassist 3.18. After that everything works fine.

jingyulee commented 10 years ago

Schleuse: how do you do with the javaassist 3.18??so you use the javaassist 3.18 the makegood works so fine??

thanks

Schleuse commented 10 years ago

I searched in my eclipse installation for javassist.jar and found it in C:\Program Files\Eclipse\configuration\org.eclipse.osgi\567\0\.cp\lib\javassist-3.11.0.

I got the javaassist 3.18 jar from here https://github.com/jboss-javassist/javassist/releases

jingyulee commented 10 years ago

Schleuse: My OS is mac. so i find the org.eclipse.osgi folder.but i can not find the .cp/lib/javassist-3.11.0. So thanks your answer.let me know possible processing methods. i will be try find the javassist-3.11.0.

thanks

jingyulee commented 10 years ago

iteman but my java use the jdk 1.7 so i don't know

iteman commented 10 years ago

@Archanciel @jingyulee @Schleuse Could you try the dev version from https://github.com/piece/makegood/releases/tag/untagged-af427bd0c15a76bd3b6d ?

jingyulee commented 10 years ago

@iteman OK. I try to use the dev version. that is work. an i can look the makegood preferences. good:) But the eclipse log. screen shot 2014-07-19 at 2 21 36

iteman commented 10 years ago

@jingyulee Thank you. What is your PDT version?

jingyulee commented 10 years ago

@iteman i use the Eclipse for PHP Developers. eclipse 4.4 and PDT is 3.3. thanks screen shot 2014-07-19 at 8 54 08

Archanciel commented 10 years ago

I did try version 3.1.1. Property dialog now ok. Could make it run and debug my tests using PHPUnit 4.1.4 installed with Composer and this preload file:

<?php
    // Setup the path related constants.
    define ( 'DS', DIRECTORY_SEPARATOR );
    require dirname ( dirname ( __FILE__ ) ) . DS . 'composer' . DS . 'vendor' . DS . 'autoload.php';
?>

But I still have to include my PEAR library in which an old version of PHPUnit (3.7.28) is installed so that class PHPUnit_Framework_TestCase can be found. I would like to stop depending on PEAR, but I don't know where to find the class PHPUnit_Framework_TestCase in PHPUnit 4.1.4 !

iteman commented 10 years ago

@Archanciel Thank you for testing MakeGood. Is the composer directory necessary? By the way, DIRECTORY_SEPARATOR seems not to be necessary for require. If your preload script is located in the PROJECT_ROOT/tests directory, it might look like this:

<?php
...
require dirname(__DIR__) . '/vendor/autoload.php';
...
Archanciel commented 10 years ago

Thanks, you are right, I was able to run my tests with MakeGood without adding any special library in the PHP project include path. I've been confused by Eclipse which seem to retain garbage information when you play with the PHP include path. I should have had restarted Eclipse after purging manuallly the .metadata.plugins\org.eclipse.dltk.core.index.sql.h2 folder, I think.

iteman commented 10 years ago

@Archanciel It's good :smile:

@jingyulee I don't know how to reproduce BadBytecode error. Could you try to launch Eclipse with the -clean option?

jingyulee commented 10 years ago

@iteman I try to add -clean option and run.but also i has the error. screen shot 2014-07-23 at 10 26 03

iteman commented 10 years ago

@jingyulee Thank you. Could you try to create a new Eclipse installation and install PDT, MakeGood 3.1.1?

jingyulee commented 10 years ago

@iteman I try to install new eclipse and install MakeGood 3.1.1. It also has the same error. i install the eclipse php package 4.4. screen shot 2014-07-23 at 11 29 14

iteman commented 10 years ago

@jingyulee OK, I will check the problem with Eclipse for PHP Developers.

devmetal commented 10 years ago

Hi, i got the same error with the new eclipse for php. error

eclipse.buildId=4.4.0.I20140606-1215 java.version=1.8.0_11 java.vendor=Oracle Corporation BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=hu_HU Framework arguments: -product org.eclipse.epp.package.php.product Command-line arguments: -os win32 -ws win32 -arch x86 -product org.eclipse.epp.package.php.product

org.eclipse.equinox.registry Error Wed Aug 06 14:04:50 CEST 2014 Unable to create the selected preference page.

java.lang.ClassNotFoundException: An error occurred while automatically activating bundle com.piece_framework.makegood.ui (347). at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:116) at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:531) at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:324) at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:311) at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:386) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:336) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:328) at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160) at java.lang.ClassLoader.loadClass(Unknown Source) at org.eclipse.osgi.internal.framework.EquinoxBundle.loadClass(EquinoxBundle.java:568) at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:174) at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:905) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243) at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:55) at org.eclipse.ui.internal.util.Util.safeLoadExecutableExtension(Util.java:873) at org.eclipse.ui.internal.menus.CompatibilityWorkbenchWindowControlContribution.construct(CompatibilityWorkbenchWindowControlContribution.java:54) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55) at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:888) at org.eclipse.e4.core.internal.di.InjectorImpl.inject(InjectorImpl.java:120) at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:337) at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:271) at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:186) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:107) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:73) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:50) at org.eclipse.e4.ui.workbench.renderers.swt.ToolControlContribution.createControl(ToolControlContribution.java:65) at org.eclipse.jface.action.ControlContribution.fill(ControlContribution.java:101) at org.eclipse.jface.action.ToolBarManager.update(ToolBarManager.java:365) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer$3.handleEvent(ToolBarManagerRenderer.java:205) at org.eclipse.e4.ui.services.internal.events.UIEventHandler$1.run(UIEventHandler.java:40) at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:187) at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:156) at org.eclipse.swt.widgets.Display.syncExec(Display.java:4734) at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:218) at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:36) at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197) at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197) at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148) at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135) at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78) at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39) at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:81) at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59) at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374) at org.eclipse.e4.ui.model.application.ui.impl.UIElementImpl.setVisible(UIElementImpl.java:345) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarContributionRecord.updateVisibility(ToolBarContributionRecord.java:73) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer$10.changed(ToolBarManagerRenderer.java:510) at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:110) at org.eclipse.e4.core.internal.contexts.EclipseContext.runAndTrack(EclipseContext.java:319) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processAddition(ToolBarManagerRenderer.java:502) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.generateContributions(ToolBarManagerRenderer.java:471) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processContribution(ToolBarManagerRenderer.java:430) at org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.createWidget(ToolBarManagerRenderer.java:391) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:983) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:662) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:766) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:737) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:731) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:715) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.handleEvent(PartRenderingEngine.java:289) at org.eclipse.e4.ui.services.internal.events.UIEventHandler$1.run(UIEventHandler.java:40) at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:187) at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:156) at org.eclipse.swt.widgets.Display.syncExec(Display.java:4734) at org.eclipse.e4.ui.internal.workbench.swt.E4Application$1.syncExec(E4Application.java:218) at org.eclipse.e4.ui.services.internal.events.UIEventHandler.handleEvent(UIEventHandler.java:36) at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:197) at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:197) at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148) at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:135) at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:78) at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:39) at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:81) at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:59) at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374) at org.eclipse.emf.ecore.util.EcoreEList.dispatchNotification(EcoreEList.java:249) at org.eclipse.emf.common.notify.impl.NotifyingListImpl.addUnique(NotifyingListImpl.java:356) at org.eclipse.emf.common.util.AbstractEList.add(AbstractEList.java:341) at org.eclipse.e4.ui.internal.workbench.ContributionsAnalyzer.processAddition(ContributionsAnalyzer.java:369) at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarRenderer.addTrimContributions(TrimBarRenderer.java:194) at org.eclipse.e4.ui.workbench.renderers.swt.TrimBarRenderer.processContents(TrimBarRenderer.java:166) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:674) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$6.run(PartRenderingEngine.java:547) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:531) at org.eclipse.e4.ui.workbench.renderers.swt.WBWRenderer.processContents(WBWRenderer.java:687) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:674) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:766) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:737) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:731) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:715) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1078) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:236) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603) at org.eclipse.equinox.launcher.Main.run(Main.java:1465) Caused by: org.osgi.framework.BundleException: Exception in com.piece_framework.makegood.ui.Activator.start() of bundle com.piece_framework.makegood.ui. at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:792) at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:721) at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:936) at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:319) at org.eclipse.osgi.container.Module.doStart(Module.java:571) at org.eclipse.osgi.container.Module.start(Module.java:439) at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:454) at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:107) ... 121 more Caused by: java.lang.RuntimeException: java.io.IOException: invalid constant type: 15 at javassist.CtClassType.getClassFile2(CtClassType.java:203) at javassist.CtClassType.subtypeOf(CtClassType.java:303) at javassist.bytecode.stackmap.TypeData$TypeName.update(TypeData.java:274) at javassist.bytecode.stackmap.TypeData$TypeName.setType(TypeData.java:203) at javassist.bytecode.stackmap.TypeData.setType(TypeData.java:46) at javassist.bytecode.stackmap.Tracer.checkParamTypes(Tracer.java:908) at javassist.bytecode.stackmap.Tracer.doInvokeMethod(Tracer.java:813) at javassist.bytecode.stackmap.Tracer.doOpcode148_201(Tracer.java:615) at javassist.bytecode.stackmap.Tracer.doOpcode(Tracer.java:101) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:161) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:120) at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:96) at javassist.bytecode.MethodInfo.rebuildStackMap(MethodInfo.java:404) at javassist.bytecode.MethodInfo.rebuildStackMapIf6(MethodInfo.java:389) at javassist.expr.ExprEditor.doit(ExprEditor.java:112) at javassist.CtBehavior.instrument(CtBehavior.java:659) at com.piece_framework.makegood.aspect.org.eclipse.php.core.aspect.SystemIncludePathAspect.weaveIntoPHPSearchEngine(SystemIncludePathAspect.java:78) at com.piece_framework.makegood.aspect.org.eclipse.php.core.aspect.SystemIncludePathAspect.doWeave(SystemIncludePathAspect.java:51) at com.piece_framework.makegood.aspect.Aspect.weave(Aspect.java:28) at com.piece_framework.makegood.aspect.AspectWeaver.weaveAspects(AspectWeaver.java:119) at com.piece_framework.makegood.aspect.AspectWeaver.weave(AspectWeaver.java:55) at com.piece_framework.makegood.ui.Activator.start(Activator.java:43) at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:771) at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1) at java.security.AccessController.doPrivileged(Native Method) at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:764) ... 128 more Caused by: java.io.IOException: invalid constant type: 15 at javassist.bytecode.ConstPool.readOne(ConstPool.java:1027) at javassist.bytecode.ConstPool.read(ConstPool.java:970) at javassist.bytecode.ConstPool.(ConstPool.java:127) at javassist.bytecode.ClassFile.read(ClassFile.java:716) at javassist.bytecode.ClassFile.(ClassFile.java:103) at javassist.CtClassType.getClassFile2(CtClassType.java:190) ... 158 more

iteman commented 10 years ago

@jingyulee I've just released v3.1.1-dev2. Could you try it from https://github.com/piece/makegood/releases/tag/v3.1.1-dev2 ?

jingyulee commented 10 years ago

@iteman Hi i, I try to use the v3.1.1-dev2.look like ok.and before the error does not happen.My OS mac os 10.9 and Eclipse for PHP Developers. 4.4.

thanks :)

iteman commented 10 years ago

@jingyulee OK, I will release v3.1.1 on this weekend. Thanks.

Archanciel commented 10 years ago

Hi,

I did try the 3x.1.1-dev2 version and it seems to work as good as the dev1 version. No problem detected !

Regards, Jean-Pierre

Mon site internet, une mine d'information audio: plusconscient.net

2014-08-27 15:47 GMT+02:00 KUBO Atsuhiro notifications@github.com:

@jingyulee https://github.com/jingyulee I've just released v3.1.1-dev2. Could you try it from https://github.com/piece/makegood/releases/tag/v3.1.1-dev2 ?

— Reply to this email directly or view it on GitHub https://github.com/piece/makegood/issues/59#issuecomment-53574243.

iteman commented 10 years ago

@Archanciel Thank you!