Closed Bishoy-at-pieces closed 1 month ago
aha , got . thanks . on it .
Let me know if you want the code snippet for making select menus and you can continue on it and make it working in the list models,assets or any other index based selection
yeah sure , if you have that , I'd rather work with that rather than reinventing the wheel . I'll try to implement that for the assets , apps and models , those three are what I believe are the index based sections in the list_command code
Yupp sure here you go https://bishoyatpieces.pieces.cloud/?p=c787439ee9, but before you add anything I would like to discuss more about it in #140 and know how it will exactly work. I think the open command should be removed now since we won't use it also the change model we will need to discuss it first before you do anything
@sambhavnoobcoder also feel free to share your thoughts in #140
@sambhavnoobcoder let me know if you faced an issue or you need any sort of help from me
sure , working on it rn , will inform you if I face any issues , will most probably share a screen recording to verify if the behaviour after the change is as expected .
https://github.com/user-attachments/assets/95c9b307-dad3-4cef-bd35-e3e2f13b40db
@Bishoy-at-pieces does this replicate the expected behaviour ? Running it opens the selection menu , and selecting the file opens it up . does this align with the functionalities required in the issue ?
Yes nice open a pull request for it! Well done!!
But wanted to know why we changed the way of opening the snippet? Just let it open as it is (gonna change it later but for now i think it is better to consontrate on one task)
okay , so just to be clear ,what you are saying is that for this issue , we just want the code that allows us to select the asset from the possible list of assets , using the select menu , and then using separate line of code , we call the open_asset command from the AssetCommand class to open the selected asset as done previously ?and we can integrate the open_asset to work from inside the select menu directly later ?
Exactly
For later I would like to change the behavior of the open command. Just for now, when you select an asset you gonna run the open_asset method in the AssetsCommands class
okay got it . I may have overstepped a bit here, but no worries , I'll make it behave accordingly for the timebeing , and will raise a pr accordingly . we can work to change the behaviour of the open command in the future .
Thank you!
created PR #149 to address this issue . kindly give it a look .
Hey @Bishoy-at-pieces , just confirming , this used to be the output when running the list command for assets earlier :
but after the change I made , it looks like this :
is this the change you were seeking in this issue ? if yes , then I can push the code . if not , kindly do tell me the changes you wanted here and I'll make them accordingly.