search

pieces-app / documentation

Official documentation for Pieces for Developers
https://docs.pieces.app
402 stars 50 forks source link

feat: adding LightHouse Github action #334

Closed CBID2 closed 7 months ago

CBID2 commented 7 months ago

Description

This PR adds workflow that runs lighthouse checks on any page that has been edited.

Issue

Closes #280

[!NOTE] This is still a work-in progress @mason-at-pieces. I'm going to test this by creating a test repo. Be on the lookout for this.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Apr 10, 2024 10:47pm
mason-at-pieces commented 7 months ago

@CBID2 This is great, thank you! Were you able to get the action to run?

CBID2 commented 7 months ago

@CBID2 This is great, thank you! Were you able to get the action to run?

Thanks @mason-at-pieces! :) I have to test it first

CBID2 commented 7 months ago

@CBID2 This is great, thank you! Were you able to get the action to run?

Hey @mason-at-pieces! :) Here is a repo that I created to test the GitHub action. Can you fork and send a PR to it so I can see if it works?

mason-at-pieces commented 7 months ago

@CBID2 could you remove pieces.app from the list of URLs to check? Eventually, that list will be automatically generated based on what pages have changes to them.

Also, after we get this first test working with docs.pieces.app, it would be great if we could use the preview deployment link that vercel gives us instead of docs.pieces.app. You can read about how to do that here: https://github.com/orgs/vercel/discussions/439

CBID2 commented 7 months ago

@CBID2 could you remove pieces.app from the list of URLs to check? Eventually, that list will be automatically generated based on what pages have changes to them.

Also, after we get this first test working with docs.pieces.app, it would be great if we could use the preview deployment link that vercel gives us instead of docs.pieces.app. You can read about how to do that here: https://github.com/orgs/vercel/discussions/439

Hi @mason-at-pieces. I removed the pieces.appURL. As far as adding the deployment link, that would mean adding another GitHub Action to it, which might be a bit difficult. So, I'm going to try a different approach.

CBID2 commented 7 months ago

@CBID2 could you remove pieces.app from the list of URLs to check? Eventually, that list will be automatically generated based on what pages have changes to them.

Also, after we get this first test working with docs.pieces.app, it would be great if we could use the preview deployment link that vercel gives us instead of docs.pieces.app. You can read about how to do that here: https://github.com/orgs/vercel/discussions/439

Hi @mason-at-pieces! :) I made some changes on my test repo with your suggestion. Can you do a test PR to it please? It'll help me make an assessment.

mason-at-pieces commented 7 months ago

Hey @CBID2, I noticed that you are using the vercel preview link in the workflow which isn't on your forked repo. We may just have to merge this in to test it out haha

CBID2 commented 7 months ago

Hey @CBID2, I noticed that you are using the vercel preview link in the workflow which isn't on your forked repo. We may just have to merge this in to test it out haha

Ok @mason-at-pieces. Merge time