search

pieces-app / documentation

Official documentation for Pieces for Developers
https://docs.pieces.app
402 stars 50 forks source link

fix:corrected pynvim installation instruction in neovim plugin docs #563

Closed Debajyati closed 2 months ago

Debajyati commented 2 months ago

562

This PR updates the documentation to provide the correct installation command for pynvim on Debian-based systems. Previously, the documentation suggested using pip install pynvim, which always leads to errors in externally managed environments.

By using sudo apt install python3-pynvim, users can ensure that pynvim is installed correctly and can be used by the plugin.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Aug 31, 2024 6:55am
hra42 commented 2 months ago

@shivay-at-pieces @Debajyati isn't #567 related to that and should be done in one PR?

Debajyati commented 2 months ago

I mean I was confused! I asked some people about when someone ( a maintainer ) reviews the PR and requests some changes then should I create a new branch and send a new PR from it or do just the changes in the same branch and send a PR? They suggested me to make a new PR from a fresh new branch. So this is why I did this.

hra42 commented 2 months ago

@Debajyati ah okay. If the pieces team wants it that way, then it's fine. Just found it confusing if you have multiple pr's for a nearly identical issue.

Debajyati commented 2 months ago

Hey just asking, what do of a PR that is not going to get merged?

hra42 commented 2 months ago

you could close that pr and work on the new pr only. Otherwise about the status we need to wait until the team takes a look at this.

Debajyati commented 2 months ago

Ok, thanks. So I will close this PR and make the changes you requested in the new PR I send last time. I will remove Debian from the line I added in the docs in the new PR. Because only Ubuntu 22+ and Ubuntu based distros are supported.

Is that all good! See I am learning contributions through making contributions. I am not very pro at it. I have read many articles but they only scratch the surface about source control. Real world is much much more to learn.