Closed codesections closed 6 years ago
Thanks! I appreciate the contrib.
Oops! I forgot to mention that safe
and striptags
both need to be present for HTML stripping to occur. I didn't properly check and it actually will render then HTML (which is not what it should do for the sake of consistency)
I've documented my confusion here - https://github.com/Keats/gutenberg/issues/286 - but it seems like a wontfix
Fixed it! Again, thanks for making the contrib. I've been meaning to fix this and your help pushed me to finally get off my ass and do it.
Thanks! I didn't realize that the intended behavior was for it to render plain text—I tend to want to render the HTML in my summaries. But I should have figured it out with striptags
in there!
By the way, the reason I made these pull requests is that I'm trying to put together a live demo of the currently avalible Gutenberg themes. The site that demostrates Feather is at https://feather--gutenberg-theme-demo.netlify.com/ if you're interested.
On Sun, Jul 15, 2018, at 2:57 PM, doomy wrote:
Fixed it! Again, thanks for making the contrib. I've been meaning to fix this and your help pushed me to finally get off my ass and do it.
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/piedoom/feather/pull/14#issuecomment-405121424
Oh that's an awesome idea! If you ever need any assistance I'd be happy to help.
This pull request suggests using the
safe
Tera filter to so that the HTML will display properly on the home page rather than having the home page display escaped HTML tags.