piegamesde / BlockMap

An out-of-game map renderer and viewer for Minecraft 1.13–1.18 worlds [unmaintained]
MIT License
92 stars 22 forks source link

Ambiguous error message #57

Closed ComputerJock closed 3 years ago

ComputerJock commented 3 years ago

I loaded a 1.12 world. I got tons of messages:

20-08-02 15:39:56 WARN RegionRenderer [130] - Skipping chunk because it is too old

Does it mean that the minecraft version of the world is too old (not supported)? Or does it mean that some timestamp on a chunk is too long in the past? If the latter, is there a way to ignore the error and render the chunk anyway?

piegamesde commented 3 years ago

Let's look at the code:

if (version < MinecraftVersion.MC_1_13.minVersion) {
    log.warn("Skipping chunk because it is too old");
    metadata.put(chunkPos, new ChunkMetadataVersion(chunkPos, "This chunk was written from Minecraft <1.13, which is not supported", version));
    continue;
}
  1. The error message could be better, I'll change this
  2. A different error message is written to the metadata for that chunk, that explains it fairly well. When viewing skipped chunks in the GUI, there should be a pop-up that explains all the details.
ComputerJock commented 3 years ago

Thanks for the explanation. Perhaps a message when the world is selected saying 'minecraft version xxx is not supported' would be helpful.

ComputerJock commented 3 years ago

comment is above

piegamesde commented 3 years ago

Perhaps a message when the world is selected saying 'minecraft version xxx is not supported' would be helpful.

The problem with this is that the Minecraft version is not some attribute to a world, but instead to each individual chunk. So sadly, this is not trivially possible