search

piekstra / tplink-cloud-api

A Python library to remotely control TP-Link smart home devices using their cloud service - no need to be on the same network as your devices
GNU General Public License v3.0
41 stars 11 forks source link

Widen requirement version restrictions #49

Closed ShayBox closed 3 years ago

ShayBox commented 3 years ago

It's not recommended to explicitly declare a dependency version unless absolutely required, and only major versions should break anything, the recommended way to restrict dependency versions is by their major version.

It also breaks compatibility with any other package that depends on the same dependencies, which in the case of requests is a lot.

https://packaging.python.org/discussions/install-requires-vs-requirements/ image

piekstra commented 3 years ago

Great callout on the intall_requires, though reading through the linked documentation it looks like leaving the dependencies in the requirements.txt file pinned to particular versions is expected. I would be happy to merge the PR with just the setup.py change.

Specifically: image

ShayBox commented 3 years ago

I didn't see that, good to know