search

piemonte / PBJVision

📸 iOS Media Capture – features touch-to-record video, slow motion, and photography
MIT License
1.93k stars 324 forks source link

Expose _captureSession.automaticallyConfiguresApplicationAudioSession property #308

Closed CAMOBAP closed 7 years ago

CAMOBAP commented 8 years ago

Problem

I faced with case when I need mix micro audio with background audio (audio form iTunes player).

I have found solution to achieve this, one of step of this solution require

AVCaptureSession *session = [[AVCaptureSession alloc] init];
session.automaticallyConfiguresApplicationAudioSession = NO;

I noticed that PBJVision expose 'similar' property _captureSession.usesApplicationAudioSession so I think this isn't a big deal to add another one

Proposed solution

add @property (nonatomic) BOOL automaticallyConfiguresApplicationAudioSession; to PBJVision class (I can prepare a pull request if needed)

CAMOBAP commented 8 years ago

Pull request ready https://github.com/piemonte/PBJVision/pull/312

CAMOBAP commented 7 years ago

@piemonte may I know the reason why it wasn't accepted?

piemonte commented 7 years ago

sorry @camobap795 i thought it had been merged. can look at it for you tomorrow.

piemonte commented 7 years ago

it looks like it was merged in, is there another PR?

CAMOBAP commented 7 years ago

@piemonte yes you are right, sorry for misleading

piemonte commented 7 years ago

@camobap795 it is no problem, thanks for the contribution ✌️️