Problem with loop in 0.13.2

piemonte / Player

▶️ Play and stream media in Swift

MIT License

2.08k stars 334 forks source link

Problem with loop in 0.13.2 #223

Open Czajnikowski opened 5 years ago

Czajnikowski commented 5 years ago

Currently if I set up Player like:

let player = Player()
player.playbackLoops = true

And then set the local URL + play() on it I'm getting it played only once. I checked what PlayerPlaybackDelegate reports and it reports a couple of playerCurrentTimeDidChanges and then playerPlaybackDidEnd.

Do we have a regression? It was (and still) works fine in 0.13.1

piemonte commented 5 years ago

hey @Czajnikowski seems like this commit is the only thing that could be causing this.

d67e7d7f6bc4dfd7c36ecb95a9d7ddcc5b4cbf58

will revert it from master. could you let me know if it works OK for you?

Czajnikowski commented 5 years ago

Hey @piemonte , thanks for your prompt reply 🙂

I have given it a try on my local clone and reverting it doesn't seem to do the trick.

yueno12 commented 4 years ago

paulocoutinhox commented 4 years ago

Hi. It was solved?