Closed dazzag24 closed 3 years ago
Yes, I took them out on purpose for the reasons I noted in the commit message. I think they are cool features, especially file transfer, but they aren't a priority for me and I didn't know for sure how to port them. A PR to add them back would be considered for sure.
OK makes sense as neither was crucial to the main purpose.
However it probably makes sense to also remove the /opt/easydav and gotty components from the base image and also cleanup the links from the index.html
Thanks
Agreed, it should be cleaned up. If you want to send a PR that would be great. Or I can try to do this next time I update the versions of Slicer.
In the latest image the shell term and file management links both result in 502 bad gateway errors.
docker run -d -p 8080:8080 --name slicer stevepieper/slicer:4.11.20200930
Logs from the docker container:
Looks like these were deliberately removed:
https://github.com/pieper/SlicerDockers/commit/98f8a1d841354f2c4757a792562a9cc8b18499d9
???